[PATCH] D62524: [clang-tidy] Fix description for misc-definitions-in-headers.

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 28 07:20:35 PDT 2019


gribozavr accepted this revision.
gribozavr added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clang-tidy/misc/DefinitionsInHeadersCheck.cpp:133
+        << IsFullSpec << FD;
+    diag(FD->getLocation(), /*FixDescription=*/"make 'inline'",
+         DiagnosticIDs::Note)
----------------
"mark as inline"?

IDK, "make inline" does not read right to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62524/new/

https://reviews.llvm.org/D62524





More information about the cfe-commits mailing list