[PATCH] D62514: [CodeComplete] Set preferred type for qualified-id

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 28 04:40:42 PDT 2019


kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

thanks, lgtm.

one irrelevant question though, it looks like most of the calls to `ResultBuilder::setPreferredType` performs a `!isNull` check before hand. should we perform this check implicitly and make the `setPreferredType` no-op in case of a null type?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62514/new/

https://reviews.llvm.org/D62514





More information about the cfe-commits mailing list