[PATCH] D62404: [clang-tidy] Fix null pointer dereference in readability-identifier-naming

[Haojian Wu via Phabricator via cfe-commits]

hokein accepted this revision.
hokein added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:804
+        if (const auto *Typedef = TypePtr->getAs<TypedefType>()) {
+          addUsage(NamingCheckFailures, Typedef->getDecl(),
+                   Value->getSourceRange());
----------------
aaron.ballman wrote:
> madsravn wrote:
> > hokein wrote:
> > > We are risky of dereferencing a nullptr, as the `TypePtr` can be null now.
> > Are we not checking for null in the line where `TypePtr` gets declared? Or am I misunderstanding? 
> I don't see a null pointer dereference here for `TypePtr`; I think the code is fine as-is.
Ah, I missed the if statement, it is guarded by the `if` statement.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62404/new/

https://reviews.llvm.org/D62404