[PATCH] D62391: [CodeComplete] Complete 'return true/false' in boolean functions

Tue May 28 01:36:35 PDT 2019

I don't think it's related. All the changes are in code completion code,
which is not run during normal compiles.

On Tue, May 28, 2019 at 2:36 AM Mike Lothian via Phabricator <
reviews at reviews.llvm.org> wrote:

> FireBurn added a comment.
>
> Could this commit be causing the following build failure of Chromium, this
> same version build a few days ago with clang from git:
>
> FAILED:
> obj/third_party/blink/renderer/bindings/core/v8/bindings_core_impl/v8_feature_policy.o
> clang++ -MMD -MF
> obj/third_party/blink/renderer/bindings/core/v8/bindings_core_impl/v8_feature_policy.o.d
> -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1
> -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD
> -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -D_FILE_OFFSET_BITS=64
> -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE
> -DCR_CLANG_REVISION=\"360094-5\" -D__STDC_CONSTANT_MACROS
> -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DNDEBUG -DNVALGRIND
> -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DBLINK_CORE_IMPLEMENTATION=1
> -DENABLE_IPC_FUZZER -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32
> -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DGL_GLEXT_PROTOTYPES
> -DUSE_GLX -DUSE_EGL -DVK_NO_PROTOTYPES -DBLINK_IMPLEMENTATION=1
> -DINSIDE_BLINK -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0
> -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX
> -DABSL_ALLOCATOR_NOTHROW=1 -DNO_MAIN_THREAD_WRAPPING
> -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1
> -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE
> -DUCHAR_TYPE=uint16_t -DGOOGLE_PROTOBUF_NO_RTTI
> -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DSK_HAS_PNG_LIBRARY
> -DSK_HAS_WEBP_LIBRARY
> -DSK_USER_CONFIG_HEADER=\"../../skia/config/SkUserConfig.h\"
> -DSK_HAS_JPEG_LIBRARY
> -DSK_VULKAN_HEADER=\"../../skia/config/SkVulkanConfig.h\" -DSK_VULKAN=1
> -DSK_SUPPORT_GPU=1
> -DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\"
> -DVK_NO_PROTOTYPES -DV8_DEPRECATION_WARNINGS -DLEVELDB_PLATFORM_CHROMIUM=1
> -DLEVELDB_PLATFORM_CHROMIUM=1 -DWTF_USE_WEBAUDIO_FFMPEG=1
> -DSUPPORT_WEBGL2_COMPUTE_CONTEXT=1 -DUSE_SYSTEM_LIBJPEG
> -DV8_DEPRECATION_WARNINGS -DUSE_SYSTEM_ZLIB=1 -I../.. -Igen
> -Igen/shim_headers/zlib_shim -I../../third_party/libyuv/include
> -Igen/shim_headers/libpng_shim -Igen/shim_headers/libwebp_shim
> -Igen/shim_headers/libdrm_shim -Igen/shim_headers/re2_shim
> -Igen/shim_headers/snappy_shim -I../../third_party/khronos -I../../gpu
> -I../../third_party/vulkan/include -Igen/third_party/dawn
> -I../../third_party/dawn/src/include
> -I../../third_party/boringssl/src/include
> -I../../third_party/webrtc_overrides -I../../third_party/webrtc
> -Igen/third_party/webrtc -I../../third_party/abseil-cpp
> -I../../third_party/ced/src -I../../third_party/icu/source/common
> -I../../third_party/icu/source/i18n -I../../third_party/protobuf/src
> -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/skia
> -I../../third_party/vulkan/include
> -I../../third_party/skia/third_party/vulkanmemoryallocator
> -I../../third_party/vulkan/include -I../../third_party/angle/include
> -I../../third_party/angle/src/common/third_party/base -Igen/angle
> -I../../third_party/angle/include -I../../v8/include -Igen/v8/include
> -I../../third_party/libwebm/source -I../../third_party/leveldatabase
> -I../../third_party/leveldatabase/src
> -I../../third_party/leveldatabase/src/include -I../../third_party/iccjpeg
> -I../../third_party/ots/include -I../../v8/include -Igen/v8/include
> -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector
> -funwind-tables -fPIC -pthread -fcolor-diagnostics -fmerge-all-constants
> -fcrash-diagnostics-dir=../../tools/clang/crashreports -Xclang -mllvm
> -Xclang -instcombine-lower-dbg-declare=0 -m64 -march=x86-64
> -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__=
> -no-canonical-prefixes -Wall -Wextra -Wimplicit-fallthrough -Wthread-safety
> -Wextra-semi -Wno-missing-field-initializers -Wno-unused-parameter
> -Wno-c++11-narrowing -Wno-unneeded-internal-declaration
> -Wno-undefined-var-template -Wno-ignored-pragma-optimize -O2 -fno-ident
> -fdata-sections -ffunction-sections -fno-omit-frame-pointer
> -fvisibility=hidden -Wheader-hygiene -Wstring-conversion
> -Wtautological-overlap-compare -Wexit-time-destructors
> -Wglobal-constructors -g0 -I/usr/include/glib-2.0
> -I/usr/lib64/glib-2.0/include -Wconversion -Wno-float-conversion
> -Wno-sign-conversion -Wno-implicit-float-conversion
> -Wno-implicit-int-conversion -Wno-shorten-64-to-32 -Wno-header-guard
> -I/usr/include/nss -I/usr/include/nspr -I/usr/include/libpng16
> -I/usr/include/libxml2 -I/usr/include/libxml2 -std=c++14 -fno-exceptions
> -fno-rtti -fvisibility-inlines-hidden -O3 -pipe -flto=thin -march=native -c
> gen/third_party/blink/renderer/bindings/core/v8/v8_feature_policy.cc -o
> obj/third_party/blink/renderer/bindings/core/v8/bindings_core_impl/v8_feature_policy.o
> In file included from
> gen/third_party/blink/renderer/bindings/core/v8/v8_feature_policy.cc:11:
> In file included from
> gen/third_party/blink/renderer/bindings/core/v8/v8_feature_policy.h:14:
> In file included from
> ../../third_party/blink/renderer/bindings/core/v8/generated_code_helper.h:14:
> In file included from
> ../../third_party/blink/renderer/bindings/core/v8/script_promise.h:34:
> ../../base/memory/scoped_refptr.h:291:6: error: member access into
> incomplete type 'const blink::SecurityOrigin'
>
>   ptr->AddRef();
>      ^
>
> ../../base/memory/scoped_refptr.h:177:7: note: in instantiation of member
> function 'scoped_refptr<const blink::SecurityOrigin>::AddRef' requested here
>
>   AddRef(ptr_);
>   ^
>
> ../../third_party/blink/renderer/platform/bindings/dom_wrapper_world.h:50:7:
> note: forward declaration of 'blink::SecurityOrigin'
> class SecurityOrigin;
>
>   ^
>
> 1 error generated.
>
>
> Repository:
>   rC Clang
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D62391/new/
>
> https://reviews.llvm.org/D62391
>
>
>
>

-- 
Regards,
Ilya Biryukov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190528/00098e0a/attachment-0001.html>