[PATCH] D62389: [clangd] Place cursor better after completing patterns
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon May 27 02:36:20 PDT 2019
ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.
================
Comment at: clang-tools-extra/clangd/CodeCompletionStrings.h:41
/// *Signature = "(size_type) const"
-/// *Snippet = "(${0:size_type})"
+/// *Snippet = "(${1:size_type})"
/// If set, RequiredQualifiers is the text that must be typed before the name.
----------------
hokein wrote:
> IIUC, I think we will still return `${0}` with the new behavior, `size_type` is the only placeholder here.
The comment was incorrect, we did not return `${0:}` placeholders before.
Note that behavior for function call arguments is the same in both the old and the new version.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62389/new/
https://reviews.llvm.org/D62389
More information about the cfe-commits
mailing list