[PATCH] D62437: [clang-tidy] Splits fuchsia-default-arguments

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added a comment.

Please mention renaming of existing check in Release Notes (after list of new checks).



================
Comment at: clang-tools-extra/clang-tidy/fuchsia/DefaultArgumentsDeclarationsCheck.cpp:23
+void DefaultArgumentsDeclarationsCheck::check(const MatchFinder::MatchResult &Result) {
+  const ParmVarDecl *D = Result.Nodes.getNodeAs<ParmVarDecl>("decl");
+  if (D == nullptr) return;
----------------
You could use auto instead of type because type is spelled in cast.


================
Comment at: clang-tools-extra/clang-tidy/fuchsia/DefaultArgumentsDeclarationsCheck.cpp:24
+  const ParmVarDecl *D = Result.Nodes.getNodeAs<ParmVarDecl>("decl");
+  if (D == nullptr) return;
+
----------------
Please run clang-format.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62437/new/

https://reviews.llvm.org/D62437