[PATCH] D60883: [OpenMP] Avoid emitting maps for target link variables when unified memory is used

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 24 13:38:28 PDT 2019


ABataev added a comment.

Just one question after looking at the test: how we're going to link the device variable to its host copy? I think the address should be passed to the runtime, no?



================
Comment at: lib/CodeGen/CGOpenMPRuntime.h:1628
+  /// Return whether the unified_shared_memory has been specified.
+  virtual bool hasRequiresUnifiedSharedMemory();
 };
----------------
ABataev wrote:
> Do we need to make it virtual?
Still not answered


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60883/new/

https://reviews.llvm.org/D60883





More information about the cfe-commits mailing list