[PATCH] D62404: [clang-tidy] Fix null pointer dereference in readability-identifier-naming

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

In D62404#1516243 <https://reviews.llvm.org/D62404#1516243>, @markstegeman wrote:

> I haven't yet been able to figure out how to properly add a test for this bug, since the expected result is a failure to compile while the current test/clang-tidy/readability-identifier-naming.cpp must compile to pass.
>
> Any suggestions?


The way we usually handle this is to create a separate test file that exhibits the previously crashing code with a comment saying the test case used to crash. IIRC, you can use a CHECK line to check that you get the expected error.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62404/new/

https://reviews.llvm.org/D62404