[PATCH] D37813: clang-format: better handle namespace macros
Francois Ferrand via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri May 24 09:23:32 PDT 2019
Typz marked 2 inline comments as done.
Typz added inline comments.
================
Comment at: unittests/Format/NamespaceEndCommentsFixerTest.cpp:526
EXPECT_EQ("namespace A {\n"
" int i;\n"
"} // namespace A",
----------------
Should I also fix these tests?
They already existed before this patch, but do not follow LLVM namespace indent style either.
================
Comment at: unittests/Format/NamespaceEndCommentsFixerTest.cpp:582
+ EXPECT_EQ("TESTSUITE() {\n"
+ " int i;\n"
+ "} // TESTSUITE()",
----------------
klimek wrote:
> All of the fixNamespaceEndComments tests are indented, but standard llvm style doesn't indent in namespaces at all iiuc.
Ok, understood. I can fix that.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D37813/new/
https://reviews.llvm.org/D37813
More information about the cfe-commits
mailing list