[PATCH] D62340: [clang-tidy] In TransformerClangTidyCheck, require Explanation field.
Yitzhak Mandelbaum via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri May 24 07:11:43 PDT 2019
ymandel added inline comments.
================
Comment at: clang-tools-extra/unittests/clang-tidy/TransformerClangTidyCheckTest.cpp:38
" else ", statement(T))));
+ Rule.Cases[0].Explanation = tooling::text("no explanation");
+ return Rule;
----------------
ilya-biryukov wrote:
> NIT: this might be the first place people look at when writing the check, so we might want to provide a real explanation here.
> Something like `negate condition and revert then and else branches`
will do. But, realized this is a bit ugly so sent https://reviews.llvm.org/D62390 to add support for the explanation to `makeRule`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62340/new/
https://reviews.llvm.org/D62340
More information about the cfe-commits
mailing list