[PATCH] D62156: [Sema][PR41730] Diagnose addr space mismatch while constructing objects
Anastasia Stulova via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri May 24 07:00:26 PDT 2019
Anastasia added inline comments.
================
Comment at: lib/Sema/SemaDeclCXX.cpp:8229
+ if (FTI.hasMethodTypeCVRUQualifiers()) {
+ FTI.MethodQualifiers->forEachCVRUQualifier(
[&](DeclSpec::TQ TypeQual, StringRef QualName, SourceLocation SL) {
----------------
rjmccall wrote:
> rjmccall wrote:
> > We want to catch `_Atomic`, too, so please just change this loop to ignore address-space qualifiers, using a flag to decide whether to call `setInvalidType`.
> If there aren't any qualifiers we're skipping, the flag isn't necessary.
We are skipping addr space currently. I use this flag to avoid setting declaration as invalid below if it's only qualified by an addr space.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62156/new/
https://reviews.llvm.org/D62156
More information about the cfe-commits
mailing list