[PATCH] D62389: [clangd] Place cursor better after completing patterns

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov created this revision.
ilya-biryukov added a reviewer: hokein.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
Herald added a project: clang.

By producing the $0 marker in the snippets at the last placeholder.
This produces nicer results in most cases, e.g. for

  namespace <#name#> {
    <#decls#>
  }

we now produce ${0:decls} instead of ${2:decls} and the final cursor
placement is more convenient.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D62389

Files:
  clang-tools-extra/clangd/CodeComplete.cpp
  clang-tools-extra/clangd/CodeCompletionStrings.cpp
  clang-tools-extra/clangd/CodeCompletionStrings.h
  clang-tools-extra/clangd/unittests/CodeCompletionStringsTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62389.201227.patch
Type: text/x-patch
Size: 5848 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190524/1c8600a8/attachment-0001.bin>