[PATCH] D62298: [CodeComplete] Filter override completions by function name

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3172
+    // Add a space after return type.
+    if (Chunk.Kind == CodeCompletionString::CK_ResultType) {
+      assert(!SeenTypedChunk);
----------------
kadircet wrote:
> do we expect anything but return type in the `BeforeName` or any case where we shouldn't put a space between `BeforeName` and `NameAndSignature` ?
> 
> why not let the user add a space while concatenating these two?
Maybe annotations? But not sure where they go (also not sure we should print them here).
I could move adding the space to the point where we concatenate `BeforeName` and `NameAndSignature` if that would make it clearer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62298/new/

https://reviews.llvm.org/D62298