[PATCH] D62279: Use LTO capable linker

Chris Bieneman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 23 12:40:28 PDT 2019


beanz added a comment.

In D62279#1514467 <https://reviews.llvm.org/D62279#1514467>, @winksaville wrote:

> Even with both gtest patches it still isn't working, `ninja check-all` is failing as before :(


I wouldn't expect your gtest patch to resolve the issue. The `CLANG_BOOTSTRAP_TARGETS` variable is just a list of targets in the stage 2 build to generate wrapper targets in the stage 1 build for. It allows you to run `ninja stage2-${target}` instead of having to go into the `stage2-bins` directory and run `ninja ${target}`.

> Is there a way to "force" gtest/gtest_main to get included just so I can see if there is any other `check-all` failures?

It isn't really about including the target. The issue is that there is a missing dependency. We need to make sure the `gtest` and `gtest_main` targets are built before the `check-runtimes` target (which is part of `check-all`.

> Other suggestions?

My Linux test build is chugging along. It is going to take a while since it is in a VM, but once it completes I can look and see if I can work out why rL361436 <https://reviews.llvm.org/rL361436> didn't work to add the dependency.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62279/new/

https://reviews.llvm.org/D62279





More information about the cfe-commits mailing list