[PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

Petr Penzin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 23 10:38:30 PDT 2019


penzn marked an inline comment as done.
penzn added inline comments.


================
Comment at: cfe/trunk/lib/Tooling/Refactoring/RangeSelector.cpp:229
+RangeSelector tooling::statements(StringRef ID) {
+  return RelativeSelector<CompoundStmt, getStatementsRange>(ID);
+}
----------------
penzn wrote:
> Sorry for posting here, haven't gotten my bugzilla access yet (requested though).
> 
> This breaks with Visual Studio 2017 (15.7.6):
> 
> RangeSelector.cpp(229): error C2971: '`anonymous-namespace'::RelativeSelector': template parameter 'Func': 'getStatementsRange': a variable with non-static storage duration cannot be used as a non-type argument
Fixed in https://reviews.llvm.org/D62202


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61774/new/

https://reviews.llvm.org/D61774





More information about the cfe-commits mailing list