[PATCH] D62312: [ASTImporter] Added visibility context check for CXXRecordDecl.

[Shafik Yaghmour via Phabricator via cfe-commits]

shafik added a comment.

Minor comments, I am going to run `check-lldb` now.



================
Comment at: unittests/AST/ASTImporterVisibilityTest.cpp:34
 };
+struct GetClassPattern {
+  using DeclTy = CXXRecordDecl;
----------------
`GetCXXRecordPattern` feels more consistent.


================
Comment at: unittests/AST/ASTImporterVisibilityTest.cpp:49
+// CXXRecordDecl:
+auto *ExternC = "class X;";
+auto *AnonC = "namespace { class X; }";
----------------
`const`? It is not consistent w/ the previous declarations. 


================
Comment at: unittests/AST/ASTImporterVisibilityTest.cpp:50
+auto *ExternC = "class X;";
+auto *AnonC = "namespace { class X; }";
 
----------------
`const`? It is not consistent w/ the previous declarations. 


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62312/new/

https://reviews.llvm.org/D62312