[PATCH] D62268: Add back --sysroot support for darwin header search.
James Y Knight via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 22 13:37:15 PDT 2019
jyknight added a comment.
In D62268#1512672 <https://reviews.llvm.org/D62268#1512672>, @ldionne wrote:
> This LGTM.
>
> When I did the refactor, all the code was only using `-isysroot` (and never accessing `--sysroot`), so I thought only `-isysroot` was relevant on Darwin. Seems like I was wrong.
The isysroot argument to the cc1 compiler invocation got populated from both isysroot and --sysroot in the driver, so that's why the behavior changed here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62268/new/
https://reviews.llvm.org/D62268
More information about the cfe-commits
mailing list