[PATCH] D62268: Add back --sysroot support for darwin header search.

[James Y Knight via Phabricator via cfe-commits]

jyknight created this revision.
jyknight added reviewers: ldionne, jfb.
Herald added subscribers: cfe-commits, dexonsmith.
Herald added a project: clang.

Before e97b5f5cf37e <https://reviews.llvm.org/rGe97b5f5cf37e382643b567affd714823215d0e75> ([clang][Darwin] Refactor header search path logic
into the driver), both --sysroot and -isysroot worked to specify where
to look for system and C++ headers on Darwin. However, that change
caused clang to start ignoring --sysroot.

This fixes the regression, and adds tests.

(I also note that on all other platforms, clang seems to almost
completely ignore -isysroot, but that's another issue...)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D62268

Files:
  clang/lib/Driver/ToolChains/Darwin.cpp
  clang/lib/Driver/ToolChains/Darwin.h
  clang/test/Driver/darwin-header-search-libcxx.cpp
  clang/test/Driver/darwin-header-search-system.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62268.200813.patch
Type: text/x-patch
Size: 6532 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190522/4b1a075b/attachment.bin>