[PATCH] D60883: [OpenMP] Avoid emitting maps for target link variables when unified memory is used

Gheorghe-Teodor Bercea via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 22 10:06:09 PDT 2019


gtbercea marked an inline comment as done.
gtbercea added inline comments.


================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:7956
+    // If using unified memory, no need to do the mappings.
+    if (CGF.CGM.getOpenMPRuntime().hasUnifiedAddressingSupport())
+      return;
----------------
ABataev wrote:
> Hmm, what about regular declare target declarations? Also, this is not enough. You also should not capture such variables in the captured regions.
For now, only variables under the link clause are considered for unified memory usage.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60883/new/

https://reviews.llvm.org/D60883





More information about the cfe-commits mailing list