[PATCH] D53847: [C++2a] P0634r3: Down with typename!

Wed May 22 08:54:39 PDT 2019

Rakete1111 marked an inline comment as done.
Rakete1111 added inline comments.

================
Comment at: clang/lib/Sema/SemaTemplate.cpp:3377-3379
       // FIXME: This is not quite correct recovery as we don't transform SS
       // into the corresponding dependent form (and we don't diagnose missing
       // 'template' keywords within SS as a result).
----------------
Rakete1111 wrote:
> rsmith wrote:
> > This FIXME is concerning. Is this a problem with this patch? (Is the FIXME wrong now?)
> Yes you're right, I believe it not longer applies due to the change in ParseDecl.cpp in ParseDeclarationSpecifiers.
Although I'm not that sure I fully understand what that comments alludes to.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53847/new/

https://reviews.llvm.org/D53847