[PATCH] D62187: Delete default constructors, copy constructors, move constructors, copy assignment, move assignment operators on Expr, Stmt and Decl
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 22 02:49:44 PDT 2019
- Previous message: [PATCH] D62187: Delete default constructors, copy constructors, move constructors, copy assignment, move assignment operators on Expr, Stmt and Decl
- Next message: [PATCH] D62187: Delete default constructors, copy constructors, move constructors, copy assignment, move assignment operators on Expr, Stmt and Decl
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
ilya-biryukov added a comment.
LG either way, the comments were NITs.
================
Comment at: clang/include/clang/AST/Stmt.h:1057
+ Stmt() = delete;
Stmt(const Stmt &) = delete;
----------------
gribozavr wrote:
> ilya-biryukov wrote:
> > NIT: Move the deleted declarations to the start of the class?
> > Or move the deleted declarations in other classes to the first public section?
> >
> > (For consistency)
> I put these new declarations close to the "primary" constructor.
Why not move declarations inside `Stmt` to the primary constructor too?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62187/new/
https://reviews.llvm.org/D62187
- Previous message: [PATCH] D62187: Delete default constructors, copy constructors, move constructors, copy assignment, move assignment operators on Expr, Stmt and Decl
- Next message: [PATCH] D62187: Delete default constructors, copy constructors, move constructors, copy assignment, move assignment operators on Expr, Stmt and Decl
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the cfe-commits
mailing list