[PATCH] D62225: [clang][NewPM] Fixing -O0 tests that are broken under new PM

[Eric Christopher via Phabricator via cfe-commits]

echristo added inline comments.


================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:1104-1105
       // which is just that always inlining occurs.
-      MPM.addPass(AlwaysInlinerPass());
+      // We always pass false here since according to the legacy PM logic for
+      // enabling lifetime intrinsics, we should not be compiling with O0.
+      MPM.addPass(AlwaysInlinerPass(/*InsertLifetimeIntrinsics=*/false));
----------------
Can you elaborate more here? We do turn on the always inliner at O0 which makes this comment a bit confusing.


================
Comment at: clang/test/CodeGen/aarch64-neon-fma.c:235
 // CHECK: attributes #1 ={{.*}}"min-legal-vector-width"="128"
+// CHECK: attributes [[NOUNWIND_ATTR]] = { nounwind }
----------------
Do we really need to check for it or does the autogeneration of testcases do some of this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62225/new/

https://reviews.llvm.org/D62225