[PATCH] D61923: [GWP-ASan] Mutex implementation [2].
Evgenii Stepanov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue May 21 15:45:23 PDT 2019
eugenis added inline comments.
================
Comment at: compiler-rt/lib/gwp_asan/mutex.h:27
+private:
+#include "gwp_asan/platform_specific/mutex_members.inc"
+};
----------------
What's the point of this include? You are leaking platform details into this common header anyway.
We can make the interface C-only; or use pImpl to hide the implementation; or just move the entire declaration of Mutex to the platform header.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61923/new/
https://reviews.llvm.org/D61923
More information about the cfe-commits
mailing list