[PATCH] D61909: Add Clang shared library with C++ exports
Chris Bieneman via cfe-commits
cfe-commits at lists.llvm.org
Tue May 21 14:18:11 PDT 2019
I don't want building libclang_shared to be disabled when `BUILD_SHARED_LIBS=On`. libclang_shared fulfills a completely different purpose from `BUILD_SHARED_LIBS`.
-Chris
> On May 21, 2019, at 12:20 PM, Ethan Sommer via Phabricator <reviews at reviews.llvm.org> wrote:
>
> E5ten added a comment.
>
> @beanz Wouldn't fixing this by adding OR BUILD_SHARED_LIBS to if(ARG_SHARED) in AddClang.cmake and to if (NOT LLVM_ENABLE_PIC) in clang-shlib/CMakeLists.txt to prevent making libclang_shared when BUILD_SHARED_LIBS is enabled make more sense?
>
>
> Repository:
> rC Clang
>
> CHANGES SINCE LAST ACTION
> https://reviews.llvm.org/D61909/new/
>
> https://reviews.llvm.org/D61909
>
>
>
More information about the cfe-commits
mailing list