[PATCH] D57930: [Driver] Verify GCCInstallation is valid

Tue May 21 13:06:03 PDT 2019

nickdesaulniers added a comment.

@danielmentz thanks for this patch! Some teammates are running into issues that would be fixed by this patch.

I think @srhines is asking for a test similar to what I wrote in r344941 (https://github.com/llvm/llvm-project/commit/11dadac247e677de124328077d080fe086f14d47#diff-281bd5e7ab7578a5203aff1d1d001bdd), and shouldn't be too much work (basically test that `--gcc-toolchain=<garbage>` fails in an explicit way.

Would you mind adding such a test, so we can ship this useful fix?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57930/new/

https://reviews.llvm.org/D57930