[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.
Jian Cai via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue May 21 11:06:49 PDT 2019
jcai19 marked 2 inline comments as done.
jcai19 added inline comments.
================
Comment at: clang-tools-extra/docs/clang-tidy/checks/android-cloexec-pipe2.rst:19
+
+ pipe2(pipefd, O_CLOEXEC);
----------------
srhines wrote:
> Shouldn't this be "O_NONBLOCK | O_CLOEXEC" instead? Why drop the O_NONBLOCK?
Good catch!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62049/new/
https://reviews.llvm.org/D62049
More information about the cfe-commits
mailing list