[PATCH] D62202: Work around a Visual C++ bug

Tue May 21 09:08:40 PDT 2019

probinson added a comment.

In D62202#1510414 <https://reviews.llvm.org/D62202#1510414>, @dblaikie wrote:

> Technically this violates the LLVM style guide which says "make anonymous namespaces as small as possible, and only use them for class declarations." (preferring static for functions) - https://llvm.org/docs/CodingStandards.html#anonymous-namespaces

Which argues for flagging it somehow.

> But making code work for the compilers we say we support seems reasonable to me.
> 
> What's the compiler bug - can't handle static functions as non-type template parameters in general? Are there other workarounds to consider?

Correct, static function was not permitted as a non-type template parameter.
https://developercommunity.visualstudio.com/content/problem/25334/error-code-c2971-when-specifying-a-function-as-the.html
I'm not aware of other workarounds, but I don't claim to be deeply familiar with the darker corners of C++.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62202/new/

https://reviews.llvm.org/D62202