[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS
Dmitry via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue May 21 02:24:18 PDT 2019
Dmitry.Kozhevnikov updated this revision to Diff 200432.
Dmitry.Kozhevnikov changed the repository for this revision from rCTE Clang Tools Extra to rG LLVM Github Monorepo.
Dmitry.Kozhevnikov added a comment.
moved to the monorepo
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D50993/new/
https://reviews.llvm.org/D50993
Files:
clang-tools-extra/clangd/Threading.cpp
clang-tools-extra/clangd/unittests/ClangdTests.cpp
Index: clang-tools-extra/clangd/unittests/ClangdTests.cpp
===================================================================
--- clang-tools-extra/clangd/unittests/ClangdTests.cpp
+++ clang-tools-extra/clangd/unittests/ClangdTests.cpp
@@ -1154,6 +1154,27 @@
Field(&CodeCompletion::Scope, "ns::"))));
}
+TEST_F(ClangdVFSTest, TestStackOverflow) {
+ MockFSProvider FS;
+ ErrorCheckingDiagConsumer DiagConsumer;
+ MockCompilationDatabase CDB;
+ ClangdServer Server(CDB, FS, DiagConsumer, ClangdServer::optsForTest());
+
+ const auto SourceContents = R"cpp(
+ constexpr int foo() { return foo(); }
+ static_assert(foo());
+ )cpp";
+
+ auto FooCpp = testPath("foo.cpp");
+ FS.Files[FooCpp] = SourceContents;
+
+ Server.addDocument(FooCpp, SourceContents);
+ ASSERT_TRUE(Server.blockUntilIdleForTest()) << "Waiting for diagnostics";
+ // check that we got a constexpr depth error, and not crashed by stack
+ // overflow
+ EXPECT_TRUE(DiagConsumer.hadErrorInLastDiags());
+}
+
} // namespace
} // namespace clangd
} // namespace clang
Index: clang-tools-extra/clangd/Threading.cpp
===================================================================
--- clang-tools-extra/clangd/Threading.cpp
+++ clang-tools-extra/clangd/Threading.cpp
@@ -1,5 +1,6 @@
#include "Threading.h"
#include "Trace.h"
+#include "clang/Basic/Stack.h"
#include "llvm/ADT/ScopeExit.h"
#include "llvm/Support/FormatVariadic.h"
#include "llvm/Support/Threading.h"
@@ -84,16 +85,25 @@
}
});
- std::thread(
- [](std::string Name, decltype(Action) Action, decltype(CleanupTask)) {
- llvm::set_thread_name(Name);
- Action();
- // Make sure function stored by Action is destroyed before CleanupTask
- // is run.
- Action = nullptr;
- },
- Name.str(), std::move(Action), std::move(CleanupTask))
- .detach();
+ // Manually capture Action and CleanupTask for the lack of C++14 generalized
+ // lambda captures
+ struct Callable {
+ std::string ThreadName;
+ decltype(Action) ThreadFunc;
+ decltype(CleanupTask) Cleanup;
+
+ void operator()() {
+ llvm::set_thread_name(ThreadName);
+ ThreadFunc();
+ // Make sure function stored by ThreadFunc is destroyed before Cleanup is
+ // run.
+ ThreadFunc = nullptr;
+ }
+ };
+
+ llvm::llvm_execute_on_thread_async(
+ Callable{Name.str(), std::move(Action), std::move(CleanupTask)},
+ clang::DesiredStackSize);
}
Deadline timeoutSeconds(llvm::Optional<double> Seconds) {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50993.200432.patch
Type: text/x-patch
Size: 2555 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190521/7041d03a/attachment.bin>
More information about the cfe-commits
mailing list