[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.
Kan Shengchen via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon May 20 17:59:38 PDT 2019
skan marked 2 inline comments as done.
skan added inline comments.
================
Comment at: lib/Frontend/HeaderIncludeGen.cpp:55
+ // Simplify Filename that starts with "./"
+ if (Filename.startswith("./"));
+ Filename=Filename.substr(2);
----------------
lebedev.ri wrote:
> xiangzhangllvm wrote:
> > Need remove ";" ?
> This was fixed but no test was added?
> Was some existing test failing previously? Which one?
The test is in the file 'clang_H_opt.c' which is included in this patch.
================
Comment at: lib/Frontend/HeaderIncludeGen.cpp:56
+ if (Filename.startswith("./"));
+ Filename=Filename.substr(2);
+
----------------
xbolva00 wrote:
> Formatting
formatting is done in updated patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62115/new/
https://reviews.llvm.org/D62115
More information about the cfe-commits
mailing list