[PATCH] D62065: Move dump method implementations to their respective class files

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 20 13:39:24 PDT 2019


aaron.ballman added inline comments.


================
Comment at: lib/AST/Comment.cpp:378-380
+LLVM_DUMP_METHOD void Comment::dump() const {
+  dump(llvm::errs(), nullptr, nullptr);
+}
----------------
If we're moving things around, is there a reason we should keep this in a source file as opposed to inlining it in the header? Same goes for the other trivial implementations.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62065/new/

https://reviews.llvm.org/D62065





More information about the cfe-commits mailing list