[PATCH] D62157: Remove explicit header-filter in run_clang_tidy.py

Julie Hockett via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 20 12:53:49 PDT 2019


juliehockett created this revision.
juliehockett added reviewers: alexfh, hokein.
juliehockett added a project: clang-tools-extra.

This removes the else clause that adds a default `-header-filter` flag to clang-tidy invocations from the run_clang_tidy.py script. If this clause is present, any HeaderFilterRegex settings in the `.clang-tidy` file are ignored and would have to be explicitly passed to the script each time.


https://reviews.llvm.org/D62157

Files:
  clang-tools-extra/clang-tidy/tool/run-clang-tidy.py


Index: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
===================================================================
--- clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
+++ clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
@@ -84,9 +84,6 @@
   start = [clang_tidy_binary]
   if header_filter is not None:
     start.append('-header-filter=' + header_filter)
-  else:
-    # Show warnings in all in-project headers by default.
-    start.append('-header-filter=^' + build_path + '/.*')
   if checks:
     start.append('-checks=' + checks)
   if tmpdir is not None:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62157.200349.patch
Type: text/x-patch
Size: 580 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190520/be9cd237/attachment.bin>


More information about the cfe-commits mailing list