[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library
Nico Weber via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon May 20 12:21:31 PDT 2019
thakis added a comment.
Another comment: The new binary is called TokensTest but is in a directory "Syntax". For consistency with all other unit test binaries, please either rename the binary to SyntaxTests, or rename the directory to "Tokens". (From the patch description, the former seems more appropriate.) Note the missing trailing "s" in the binary name too.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59887/new/
https://reviews.llvm.org/D59887
More information about the cfe-commits
mailing list