[PATCH] D62135: [clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to force it.
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon May 20 05:15:57 PDT 2019
kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clangd/CodeComplete.h:128
+ /// Always use text-based completion.
+ NeverParse,
+ } RunParser = ParseIfReady;
----------------
Do we really have any real use case for this option apart from testing ?
================
Comment at: clangd/tool/ClangdMain.cpp:268
+ "Always used text-based completion")),
+ llvm::cl::init(CodeCompleteOptions::ParseIfReady), llvm::cl::Hidden);
----------------
Maybe `CodeCompletionOptions().RunParser` to keep the defaults at one place
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62135/new/
https://reviews.llvm.org/D62135
More information about the cfe-commits
mailing list