[PATCH] D61837: Make it possible control matcher traversal kind with ASTContext

Stephen Kelly via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 17 05:37:33 PDT 2019


steveire marked an inline comment as done.
steveire added inline comments.


================
Comment at: lib/ASTMatchers/ASTMatchersInternal.cpp:240
+
+  assert(RestrictKind.isBaseOf(NodeKind));
+  if (Implementation->dynMatches(N, Finder, Builder)) {
----------------
aaron.ballman wrote:
> Add an assertion message?
Saying what? The original code doesn't have one. Let's avoid round trips in review comments :).


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61837/new/

https://reviews.llvm.org/D61837





More information about the cfe-commits mailing list