[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 17 02:31:53 PDT 2019


Szelethus added a comment.

I committed but changed the moves to copies. Singel `CheckerRegisrty::CmdLineOption` is only filled with `StringRef`s, it shouldn't really matter.



================
Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:314
 insertOptionToCollection(StringRef FullName, T &Collection,
-                         const CheckerRegistry::CmdLineOption &&Option) {
+                         const CheckerRegistry::CmdLineOption &&Option,
+                         AnalyzerOptions &AnOpts) {
----------------
NoQ wrote:
> Mmm, const rvalue reference? Is this even a thing?
Apparently :D


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57922/new/

https://reviews.llvm.org/D57922





More information about the cfe-commits mailing list