[PATCH] D60763: Prototype OpenCL BIFs using Tablegen
Pierre via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri May 17 02:19:17 PDT 2019
Pierre added inline comments.
================
Comment at: clang/include/clang/Basic/OpenCLBuiltins.td:17
+//
+// Builtin functions are instances of the Builtin class.
+// Prototypes are defined as a list of Type classes (or its subclasses).
----------------
Anastasia wrote:
> Can you explain this comment please? At this point it almost feels like you are adding Clang Builtin here. May be you should refer to definition of OpenCL Builtin in this file.
I deleted this comment aswell, I feel it only adds confusion
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60763/new/
https://reviews.llvm.org/D60763
More information about the cfe-commits
mailing list