[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

Jian Cai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 16 17:54:40 PDT 2019


jcai19 created this revision.
Herald added subscribers: cfe-commits, xazax.hun, mgorny, srhines.
Herald added a project: clang.

pipe2() is better to set O_CLOEXEC flag to avoid file descriptor leakage.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D62049

Files:
  clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp
  clang-tools-extra/clang-tidy/android/CMakeLists.txt
  clang-tools-extra/clang-tidy/android/CloexecPipe2Check.cpp
  clang-tools-extra/clang-tidy/android/CloexecPipe2Check.h
  clang-tools-extra/docs/ReleaseNotes.rst
  clang-tools-extra/docs/clang-tidy/checks/android-cloexec-pipe2.rst
  clang-tools-extra/docs/clang-tidy/checks/list.rst
  clang-tools-extra/test/clang-tidy/android-cloexec-pipe2.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62049.199951.patch
Type: text/x-patch
Size: 8289 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190517/9a77a479/attachment.bin>


More information about the cfe-commits mailing list