[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Thu May 16 14:01:27 PDT 2019

Szelethus added a comment.

In D59464#1505435 <https://reviews.llvm.org/D59464#1505435>, @phosek wrote:

> In D59464#1505323 <https://reviews.llvm.org/D59464#1505323>, @Szelethus wrote:
>
> > I started to land other patches as well that depend on this one -- I won't object, but I'd prefer to find a solution, mostly because I don't even know how I could reproduce this error. The thing is, I merely moved some files from one directory to the other, which makes me scratch my head even more. That being said -- (see inlines)
>
>
> Which other changes have been landed that depend on this one?

rC360910 <https://reviews.llvm.org/rC360910>

> Our builders always perform a clean build to avoid any dirty state from previous builds. Have you tried doing a clean build with your change?

Yes, I did clean, check-clang-analysis, clean, check-all, clean, check-clang.

> 
> 
>> If it's urgent, feel free to revert, I won't be near a computer until tomorrow.
> 
> If that's the case I'd prefer to revert it to avoid having the build broken for another day.

Could you please take a look at my inline first? Could the fix be that simple? I'm really unsure as to how I could reproduce the error locally.

> In D59464#1505347 <https://reviews.llvm.org/D59464#1505347>, @Szelethus wrote:
> 
>> Also, am I supposed to receive a mail from your buildbots? I unfortunately received none.
> 
> 
> We have builders on the silent master but they aren't stable enough yet to promote to the stable master.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59464/new/

https://reviews.llvm.org/D59464