[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type name/access index

Yonghong Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 16 13:27:38 PDT 2019


yonghong-song marked an inline comment as done.
yonghong-song added inline comments.


================
Comment at: lib/CodeGen/CGExpr.cpp:3359
+    // Remember the original array subscript for bpf target
+    unsigned idx = cast<llvm::ConstantInt>(indices.back())->getZExtValue();
+    eltPtr = CGF.Builder.CreatePreserveArrayAccessIndex(addr.getPointer(),
----------------
efriedma wrote:
> I don't think there's any reason to expect the array subscript is a ConstantInt here?
right.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61809/new/

https://reviews.llvm.org/D61809





More information about the cfe-commits mailing list