[PATCH] D61835: Extract ASTDumper to a header file

Thu May 16 12:25:41 PDT 2019

steveire added a comment.

In D61835#1505228 <https://reviews.llvm.org/D61835#1505228>, @aaron.ballman wrote:

> In D61835#1505202 <https://reviews.llvm.org/D61835#1505202>, @steveire wrote:
>
> > 3. Anyone who wants traversal in the same way that dumping is done and who needs to call API on the instance which is provided by ASTNodeTraverser (which ASTDumper inherits) needs to use ASTDumper. For example my UI. See my EuroLLVM talk for more: https://steveire.wordpress.com/2019/04/30/the-future-of-ast-matching-refactoring-tools-eurollvm-and-accu/
>
>
> Do they? Why is the `ASTNodeTraverser` insufficient?

It doesn't have the same behavior as `ASTDumper`, because `ASTDumper` "overrides" some `Visit` metthods.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61835/new/

https://reviews.llvm.org/D61835