[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 16 11:27:39 PDT 2019


aaron.ballman added a comment.

In D61834#1505056 <https://reviews.llvm.org/D61834#1505056>, @steveire wrote:

> In D61834#1504665 <https://reviews.llvm.org/D61834#1504665>, @aaron.ballman wrote:
>
> > What will be making use of/testing this new functionality?
>
>
> Any code which has a `DynTypedNode` and wishes to traverse it.
>
> I envisage this as a more-flexible `DynTypedNode::dump` that the user does not have to implement themselves in order to use the `ASTNodeTraverser`.


Do we currently have any such code that's using this functionality, though? I'm mostly concerned that this is dead code with no testing, currently. The functionality itself seems reasonable enough and the code looks correct enough, so if this is part of a series of planned changes, that'd be good information to have for the review.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61834/new/

https://reviews.llvm.org/D61834





More information about the cfe-commits mailing list