[PATCH] D62010: [CodeComplete] Complete enumerators when preferred type is an enum
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 16 08:03:33 PDT 2019
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
================
Comment at: clang/test/CodeCompletion/enum-preferred-type.cpp:13
+ if (color == N::Color::Red) {}
+
+ // RUN: %clang_cc1 -fsyntax-only -code-completion-at=%s:10:11 %s -o - | FileCheck %s
----------------
Could you also add an `else if` case, with a similar fixme as in the code?
So that when someone fixes it, we can be sure that fix is working.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62010/new/
https://reviews.llvm.org/D62010
More information about the cfe-commits
mailing list