[PATCH] D61836: Move TraversalKind enum to ast_type_traits

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from some commenting requests.



================
Comment at: include/clang/AST/ASTTypeTraits.h:44
+enum TraversalKind {
+  /// Will traverse any child nodes.
+  TK_AsIs,
----------------
s/any/all ?


================
Comment at: include/clang/AST/ASTTypeTraits.h:47
+
+  /// Will not traverse implicit casts and parentheses.
+  TK_IgnoreImplicitCastsAndParentheses
----------------
Can you update the comment to more clearly state what is skipped, because it's more than just implicit casts and parentheses?

If we can find a better name for the traversal kind, then great, but I can't think of one. `IgnoreRandomImplicitJunk` doesn't seem like an improvement, despite it being more accurate. :-P


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61836/new/

https://reviews.llvm.org/D61836