[PATCH] D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

David Chisnall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 16 00:23:02 PDT 2019


theraven requested changes to this revision.
theraven added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/AST/ASTContext.cpp:6973
     QualType PointeeTy = OPT->getPointeeType();
-    if (!Options.EncodingProperty() &&
+    if (getLangOpts().ObjCRuntime.isGNUFamily() &&
+        !Options.EncodingProperty() &&
----------------
Please can we at least make this check just for the GCC runtime?  I'm not sure it's even needed there.  I've previously had to write code that works around this and have always considered it a bug in GCC, rather than a feature that I'd like us to copy, so I'd also be happy with just deleting this code path entirely.



Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61974/new/

https://reviews.llvm.org/D61974





More information about the cfe-commits mailing list