[PATCH] D61909: Add Clang shared library with C++ exports

Wed May 15 14:14:26 PDT 2019

winksaville added a comment.

In D61909#1503483 <https://reviews.llvm.org/D61909#1503483>, @beanz wrote:

> In D61909#1503433 <https://reviews.llvm.org/D61909#1503433>, @winksaville wrote:
>
> > IMHO "`BUILD_CLANG_DYLIB`" is needed. As you have it now libclang_shared.so is always builds on UNIX systems, which I believe means that all linux distros would have both increasing their sizes.
>
>
> Distributions shouldn't be installing `all` unless they really want everything and the kitchen sink. We have the `LLVM_DISTRIBUTION_COMPONENTS` so that distributions can decide which pieces of the LLVM & Clang distributions they want to install. That is the cleanest mechanism for curating an install.

Sorry, maybe I didn't make myself clear. I didn't mean distros installing "all" of LLVM. What I meant was that this change currently uses `if(UNIX)` to generate `libclang_shared.so`, which means "all linux distors" will have both `libclang*.a` and `libclang_shared.so`. Therefore, I'm suggesting the need for something like "`BUILD_CLANG_DYLIB`" so that `libclang_shared.so` is only created when "`BUILD_CLANG_DYLIB`" is `ON` and the default is `OFF`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61909/new/

https://reviews.llvm.org/D61909