[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends
Kevin P. Neal via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 15 13:14:20 PDT 2019
kpn marked an inline comment as done.
kpn added a comment.
I'm waiting for a signoff from at least one front-end guy. I hope the mode setting that allows us to keep front ends from having to touch every use of the IRBuilder is something that works for clang. But I haven't heard anything from @rsmith or any other front-end person.
================
Comment at: include/llvm/IR/IRBuilder.h:228
+ /// Enable/Disable use of constrained floating point math
+ void setIsConstrainedFP(bool IsCon) { IsFPConstrained = IsCon; }
+
----------------
kbarton wrote:
> This is a minor quibble, but the method is setIsConstrainedFP, while the member is IsFPConstrained.
> I'm not sure if that is intentionally different, or an oversight.
Yeah, that's an oversight. Fixed.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53157/new/
https://reviews.llvm.org/D53157
More information about the cfe-commits
mailing list