[PATCH] D61909: Add Clang shared library with C++ exports

Wed May 15 11:56:31 PDT 2019

winksaville added a comment.

IMHO "`BUILD_CLANG_DYLIB`" is needed. As you have it now libclang_shared.so is always builds on UNIX systems, which I believe means that all linux distros would have both increasing their sizes. I think the default should be "always" `build libclang*.a` as it is now, and optionally build `libclang_shared.so` using some flag.

And adding "`LINK_CLANG_DYLIB`" in a future patch SGTM.

================
Comment at: clang/tools/CMakeLists.txt:16
 add_clang_subdirectory(clang-refactor)
+if(UNIX)
+  add_clang_subdirectory(clang-shlib)
----------------
It seems to me we should put creating clang-shlib in the users control and default to off.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61909/new/

https://reviews.llvm.org/D61909