[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

Wed May 15 10:43:55 PDT 2019

hctim added a comment.

In D61923#1503272 <https://reviews.llvm.org/D61923#1503272>, @jfb wrote:

> Have you asked on libcxx-dev whether a stand-alone base is something of interest to them?

No, but I will follow up on that.

> Kinda... but your answer really sounds like this is a Google-only project, with intended uses only for some Google applications. That's not necessarily a bad thing, but it's really weird: my impression was that GWP and Scudo were intended to be generally usable elsewhere. Is that not the case?
> 
> Not that I expect *you* to do any porting work, but the direction you're setting just sounds like "well, we're our only users and we'll take the path that'll work for us". None of the reasoning seems to be truly technical, it's more "these projects we want to integrate into build this way, so we should fit in that way". i.e. it's more about implementation convenience than anything else. Is that the case? Implementation convenience is sometimes a good reason, but as I've outlined above I think you need to provide more thoughtful reasoning.

I definitely don't want that to be the case, or to have it come across that way. We want a reference implementation that's available for any allocator to drop in and use, with minor tweaking. As part of that, our goal is to make the requirements to support GWP-ASan as low as possible, preferably as simple as "merge this into your codebase somewhere, and you're good to go". We inherit the restrictions of each allocator's build system, which means more restrictive environment for us, but we can be drop-in supported pretty much everywhere. Our plans for this reference implementation is to use it in Android and Fuchsia, but we would love to collaborate with other interested projects to hear about what their requirements would be as well.

We discussed at length whether to have GWP-ASan be a standalone GitHub project (similar to Scudo standalone), or as part of compiler-rt. We decided to put it into compiler-rt because we can then exercise LLVM's extensive build/test/review infrastructure and open-source licensing.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61923/new/

https://reviews.llvm.org/D61923