[PATCH] D61925: [analyzer] MIGChecker: Add support for os_ref_retain().

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 14 17:10:55 PDT 2019


NoQ marked an inline comment as done.
NoQ added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp:118-119
+static const ParmVarDecl *getOriginParam(SVal V, CheckerContext &C,
+                                         bool IncludeBaseRegions = false) {
+  // TODO: We should most likely always include base regions here.
+  SymbolRef Sym = V.getAsSymbol(IncludeBaseRegions);
----------------
This is probably a source of false negatives; i'll investigate it separately.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61925/new/

https://reviews.llvm.org/D61925





More information about the cfe-commits mailing list