[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

Don Hinton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 14 12:03:43 PDT 2019


hintonda added a comment.

I'll be happy to commit for you, but will give it till tomorrow just to make sure no one else has any additional comments.

Thanks again!



================
Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize-loop-convert.rst:262
+not been used on code with a compatibility requirements of OpenMP prior to
+version 5. It is **intentional** that this check does not make any attempt to
+not issue diagnostics on OpenMP for loops.
----------------
Could you reword this last line to remove the double negative?  Perhaps something like:

```
This check makes no attempt to exclude incorrect diagnostics for OpenMP loops prior to OpenMP 5.
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61827/new/

https://reviews.llvm.org/D61827





More information about the cfe-commits mailing list